bootstrap-wysiwyg icon indicating copy to clipboard operation
bootstrap-wysiwyg copied to clipboard

Published 20 hours ago • verified publisher icon steveathon

Expanded Exec Command Options

Open rhpot1991 opened this issue 8 years ago • 4 comments

Added InsertHTML support for IE and insertFontPoint for all browsers.

rhpot1991 avatar Jan 23 '17 16:01 rhpot1991

Can you run jshint? The project is currently set up to use the Google style guide and I noticed that you removed the space from between the parenthesis. Running jshint should take care of that.

codewithtyler avatar Jan 24 '17 05:01 codewithtyler

Merging this PR results in (when clicking any toolbar button):

Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at HTMLAnchorElement.<anonymous> (bootstrap-wysiwyg.js:296)
    at HTMLAnchorElement.dispatch (jquery.min.js:3)
    at HTMLAnchorElement.r.handle (jquery.min.js:3)
(anonymous) @ bootstrap-wysiwyg.js:296
dispatch @ jquery.min.js:3
r.handle @ jquery.min.js:3

It refers to this line: else if ( editor.data( options.commandRole ).indexOf( 'fontPoint' ) >= 0 )

EDIT: this has been fixed and pushed to my fork. If you want to cherry-pick the commit, the hash is e8cdd750bc3de40ebdaee23f3224a769b502a39b

spreadred avatar Apr 04 '17 14:04 spreadred

@rhpot1991 can you pickup the changes that @kaptainkommie made for your fork so we can close off this PR?

steveathon avatar Aug 19 '17 03:08 steveathon

Bump @rhpot1991 ?

steveathon avatar Mar 10 '18 06:03 steveathon