pypi.disallow_fallback doesn't work

[pulecp]

Hello,

I would need to help with configuring pypi.disallow_fallback. It seems like any format doesn't work for me:

pypi.disallow_fallback = package1 package2

pypi.disallow_fallback =
    package1
    package2

pypi.disallow_fallback = (package1, package2)

pypi.disallow_fallback = [package1, package2]

pypi.disallow_fallback = package1, package2

I still see in logs that Pypicloud tried to search a package in an upstream even when it shouldn't look for it because it's private package:

2022-11-04 14:17:22	WARNING 2022-11-04 14:17:22,547 [pypicloud.locator] Error fetching 'package1' from upstream: 404 Client Error: Not Found for url: https://pypi.org/pypi/package1/json

Here is a part of configuration I'm using. If you need more or whole config, let me know.

pypi.always_show_upstream = true
pypi.cache_update = everyone
pypi.fallback = cache
pypi.disallow_fallback =

I'm running the newest version of Pypicloud from docker hub stevearc/pypicloud:1.3.11-alpine.

I have feeling that this option doesn't work at all.

Note: I already asked the same question in an old issue where someone had similar issue with formatting - link.

Thanks you very much for help! If you need more info, testing, just let me know.

[stevearc]

The first two formats should both work. If not, it's possible there's a bug in the logic somewhere. As per #325, I won't be working on this but since it would fall under the category of bugfix I would happily review a PR!

[pulecp]

The first two formats should both work. If not, it's possible there's a bug in the logic somewhere. As per #325, I won't be working on this but since it would fall under the category of bugfix I would happily review a PR!

You are right. Both formats are working.

There is just a wrong ordering when Pypicloud searches for releases in an upstream even when the package is listed in the pypi.disallow_fallback option. See my PR #328 with a fix.