YouTube-Music icon indicating copy to clipboard operation
YouTube-Music copied to clipboard

Search box is now part of the title bar, causing issues with selecting text via mouse

Open jscheel opened this issue 2 years ago • 2 comments

If you try to double click text in the search bar to select all, it maximizes the window. If you try to drag-select text, it moves the app window. I'm guessing this came from https://github.com/steve228uk/YouTube-Music/pull/151

jscheel avatar Apr 20 '22 13:04 jscheel

Oh no. Yeah that sounds like that other PR introduced a regression. 😅

Should we revert?

/cc @atom2ueki

TimOliver avatar Apr 20 '22 15:04 TimOliver

@jscheel @TimOliver

yes, there is an priority issue in-between search view and NSView action

https://github.com/steve228uk/YouTube-Music/blob/ad51b3ad98779e31cc73940597c6eac1b2ed1dfb/YT%20Music/Controllers/ViewController.swift#L81

https://github.com/steve228uk/YouTube-Music/blob/ad51b3ad98779e31cc73940597c6eac1b2ed1dfb/YT%20Music/Controllers/ViewController.swift#L154

these 2 places height previously was 20, when it increased to 64, NSView action will take a higher priority, I will raise a PR revert it back later

atom2ueki avatar Apr 21 '22 12:04 atom2ueki

@TimOliver Shall we close this ticket?

atom2ueki avatar Jan 04 '23 12:01 atom2ueki

Sounds good. :)

TimOliver avatar Jan 05 '23 02:01 TimOliver