steve icon indicating copy to clipboard operation
steve copied to clipboard

Move webapp folder in the default Spring Boot location

Open juherr opened this issue 8 months ago • 4 comments

Related to #1733

juherr avatar Apr 01 '25 18:04 juherr

could you please elaborate the changes?

goekay avatar Apr 02 '25 04:04 goekay

It is just moving the folder into the common folder used by spring boot for jsp. I didn't see any side effect of the changes.

juherr avatar Apr 02 '25 09:04 juherr

It is just moving the folder into the common folder used by spring boot for jsp. I didn't see any side effect of the changes.

i just question this claim about common/default folder by spring boot, because i did not encounter such a thing in my experience.

goekay avatar Apr 07 '25 09:04 goekay

As I understand it:

  • When using JSP with Spring Boot, a WAR package is required, which in turn relies on the maven-war-plugin. (https://docs.spring.io/spring-boot/reference/web/servlet.html#web.servlet.embedded-container.jsp-limitations)
  • The default warSourceDirectory for this plugin is src/main/webapp, and this value is not overridden by spring-boot-starter-parent (https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html#warSourceDirectory)

juherr avatar Apr 07 '25 13:04 juherr

Closed in favor of migrating to Thymeleaf, which is a more appropriate next step. See: https://github.com/juherr/evolve/pull/5

juherr avatar Jul 27 '25 21:07 juherr

hey @juherr could you please revert the deletion and reopen this PR?

goekay avatar Sep 18 '25 13:09 goekay

@goekay done. Feel free to update it.

juherr avatar Sep 18 '25 18:09 juherr

fixing conflicts was not fun. i abandoned it. instead, i applied the same changes on top of current HEAD in https://github.com/steve-community/steve/pull/1821

as always, thanks for the help @juherr and sorry for the unnecessary effort/trouble i caused.

goekay avatar Sep 19 '25 07:09 goekay