steve icon indicating copy to clipboard operation
steve copied to clipboard

Use Spotless

Open juherr opened this issue 2 years ago • 4 comments

juherr avatar Aug 30 '23 07:08 juherr

@slachiewicz I used the Google format by default but I saw you contributed to palantir. I've never use it. Do you have any feedback to share?

juherr avatar Aug 30 '23 09:08 juherr

Ping @goekay WDYT?

@slachiewicz Any advice between Google format and Palantir format?

juherr avatar Sep 11 '23 13:09 juherr

We use the Spotless plugin to format Maven projects. https://github.com/apache/maven-parent/blob/maven-parent-40/pom.xml#L1168-L1211

our configuration files can be found here: https://github.com/apache/maven-shared-resources/tree/master/src/main/resources/config

It works with sometimes minor issues like duplicate license headers for the first reformat, and issues with Java 21. But in general, I would recommend using Spotless - we previously used only the checkstyle plugin and that was a nightmare to fix formatting errors.

slachiewicz avatar Sep 18 '23 20:09 slachiewicz

and we disabled completely checkstyle plugin completely because with Spotless it is redundant.

slachiewicz avatar Sep 29 '23 20:09 slachiewicz

Done on https://github.com/juherr/evolve

juherr avatar Aug 27 '25 14:08 juherr