steve icon indicating copy to clipboard operation
steve copied to clipboard

Use testcontainers maven plugin for the generation of jooq code

Open juherr opened this issue 2 years ago • 11 comments

It should make compilation easier for newcomers. Close #1140

juherr avatar Jul 16 '23 17:07 juherr

hey @juherr i think this PR and the changes it introduces are cleaner than the one in #1140. therefore, i am slightly leaning towards this one.

there are failed checks though.

goekay avatar Jul 25 '23 10:07 goekay

Yes, I wanted some feedbacks before going deeper. I will try to fix the issues.

juherr avatar Jul 25 '23 10:07 juherr

when the build pipeline and infra-related stuff are updated, we can refactor tests to include testcontainers. nice initiative!

goekay avatar Jul 25 '23 10:07 goekay

Java 11 builds are failing because the plugin is build against Java 17. As Java 11 support will be dropped in 2 months, maybe we can assume to drop its support at build time (Java 11 can be still the target but build by Java 17)

Java 17 builds are failing because the database was no more ready (as not used at build time). I try to manage the migration before the tests based on your work at d5a661782d926a1c7cf4f4b3c02304ac378ac0e6 The build is ongoing ;) 🤞

juherr avatar Jul 26 '23 16:07 juherr

@goekay Everything fixed! 🎉

juherr avatar Jul 27 '23 07:07 juherr

Ping @goekay WDYT?

juherr avatar Jul 31 '23 07:07 juherr

Ping @goekay WDYT?

pls give me some time. nowadays i am constantly short on time.

goekay avatar Aug 01 '23 13:08 goekay

With update to Java 17 - Docker file also can be adjusted

slachiewicz avatar Aug 01 '23 14:08 slachiewicz

@slachiewicz step by step 😉

juherr avatar Aug 01 '23 20:08 juherr

Ping @goekay

juherr avatar Aug 20 '23 19:08 juherr

Ping @goekay

juherr avatar Sep 11 '23 12:09 juherr

Closing this PR due to inactivity. For an alternative approach, please refer to https://github.com/juherr/evolve/pull/21 for an alternative solution

juherr avatar Jul 28 '25 15:07 juherr