steve icon indicating copy to clipboard operation
steve copied to clipboard

Display all events transaction if asked

Open juherr opened this issue 3 years ago • 2 comments

Fix #1004

juherr avatar Dec 18 '22 13:12 juherr

hey, thanks for the PR but this is not as easy as this.

the flag is used at https://github.com/steve-community/steve/blob/master/src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java#L187-L192

if the flag is false, it will select the last one. we/i need to change the sql structure to allow selecting all events.

moreover, for the flag to be effective the JSP file needs to be changed with additional UI constructs for the user to interact with this property.

goekay avatar Dec 18 '22 22:12 goekay

Thank for the highlight, I didn't check the repository layer. Inwill update.

moreover, for the flag to be effective the JSP file needs to be changed with additional UI constructs for the user to interact with this property.

The idea was to hide the option and not show it in the ui: power user can add the flag in the url. But I can add an url in the view if needed.

juherr avatar Dec 19 '22 06:12 juherr

what is the state of this PR? especially, after removing firstArrivingMeterValueIfMultiple?

goekay avatar Jun 23 '24 07:06 goekay

Should be reworked

juherr avatar Jun 25 '24 06:06 juherr