OneTapCompose icon indicating copy to clipboard operation
OneTapCompose copied to clipboard

Missing exception handling

Open kelvin-dev opened this issue 1 year ago • 9 comments

Missing exception handling at the else clause, line 108, Missing exception handling

image

Thanks

kelvin-dev avatar Jul 19 '24 12:07 kelvin-dev

Thanks for your feedback! I'll take a look and update the library tomorrow hopefully!

stevdza-san avatar Jul 19 '24 18:07 stevdza-san

Thanks for your feedback! I'll take a look and update the library tomorrow hopefully!

we love your work, for further investigation, please fix below issue on your lib my dear, we already recorded the fatal log, During begin sign in, failure response from one tap: 8: [8] UNKNOWN EXCEPTION - java.lang.IllegalArgumentException: ProtoDataStoreConfig<wli> doesn't match previous call [uri=android://com.google.android.gms/files/auth_api_credentials/com.google%3Ameow.test404%40gmail.com/gislamssettings.pb] [variantConfig] that happens on new APK fresh install, Tons of thanks

kelvin-dev avatar Jul 20 '24 09:07 kelvin-dev

I've just pushed a new release, v1.0.13.

stevdza-san avatar Jul 21 '24 07:07 stevdza-san

Thanks for your feedback! I'll take a look and update the library tomorrow hopefully!

we love your work, for further investigation, please fix below issue on your lib my dear, we already recorded the fatal log, During begin sign in, failure response from one tap: 8: [8] UNKNOWN EXCEPTION - java.lang.IllegalArgumentException: ProtoDataStoreConfig<wli> doesn't match previous call [uri=android://com.google.android.gms/files/auth_api_credentials/com.google%3Ameow.test404%40gmail.com/gislamssettings.pb] [variantConfig] that happens on new APK fresh install, Tons of thanks

we pull your latest source , that issue stills persist on your high level implementation

kelvin-dev avatar Jul 21 '24 19:07 kelvin-dev

@kelvin-dev I'm not sure that the error is associated with this library. It seems you have an issue with the proto data store?

stevdza-san avatar Jul 22 '24 05:07 stevdza-san

@kelvin-dev I'm not sure that the error is associated with this library. It seems you have an issue with the proto data store?

proto data store ? we dont use any library in our dependencies, we been evaluating on fresh installs, say , Android 7, API 25, would you please have a unit test on Bluestack VMs,

kelvin-dev avatar Jul 22 '24 19:07 kelvin-dev

fyi, we dont use any lib on proto datastore

image

image

kelvin-dev avatar Jul 27 '24 21:07 kelvin-dev

@kelvin-dev I've fixed one exception handling issue in the new v1.0.13. Try updating the library and check it out?

stevdza-san avatar Jul 28 '24 05:07 stevdza-san

weve been on your version v1.0.13 so far, please fix the root cause, your lib keep throwing at that exception

kelvin-dev avatar Jul 28 '24 09:07 kelvin-dev