OneTapCompose icon indicating copy to clipboard operation
OneTapCompose copied to clipboard

Date of Birth Property Missing.

Open Hey-Deepak opened this issue 2 years ago • 5 comments

What is the Issue The user is not able to get a DOB using this solution.

What needs to be done? We need to add new params i.e. val dateOfBirth

Why this is important? In most of apps, we want to know the user's age and according to that, we need to perform certain actions. very important property.

Hey-Deepak avatar Oct 31 '23 10:10 Hey-Deepak

That property cannot be obtained directly from Google JWT, instead you need a special permission to access that information.

stevdza-san avatar Oct 31 '23 16:10 stevdza-san

Then this is a big problem for this library. How we can fix it?

On Tue, 31 Oct, 2023, 10:23 pm Stefan Jovanovic, @.***> wrote:

That property cannot be obtained directly from Google JWT, instead you need a special permission to access that information.

— Reply to this email directly, view it on GitHub https://github.com/stevdza-san/OneTapCompose/issues/12#issuecomment-1787608550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFH5SGUBMUMAZVGY52JRLYCEUIDAVCNFSM6AAAAAA6XNBRCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGYYDQNJVGA . You are receiving this because you authored the thread.Message ID: @.***>

Hey-Deepak avatar Nov 01 '23 07:11 Hey-Deepak

I'm not really sure about that. I haven't given a thought about that specific info.

stevdza-san avatar Nov 02 '23 06:11 stevdza-san

It is important for a reason. Let me give you some perspective.

DOB helps us to identify

  1. when we can wish to someone?
  2. Age restriction
  3. Today age
  4. Feature access according to age limit Etc.

Otherwise, I need to moveon from this library which I don't want. Also, I recommend about this library to my friends. I find it useful and can be used my many people So are you adding that property? Please. 🙏🙏🙏

Deepak Choudhary (Android Engineer)

On Thu, 2 Nov, 2023, 11:49 am Stefan Jovanovic, @.***> wrote:

I'm not really sure about that. I haven't given a thought about that specific info.

— Reply to this email directly, view it on GitHub https://github.com/stevdza-san/OneTapCompose/issues/12#issuecomment-1790136242, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFH5WW5NN4P7T2TFAS6UTYCM3OXAVCNFSM6AAAAAA6XNBRCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGEZTMMRUGI . You are receiving this because you authored the thread.Message ID: @.***>

Hey-Deepak avatar Nov 02 '23 06:11 Hey-Deepak

Yes, those are good use-cases. But I'm not really sure that One-Tap API will allow that information through the tokenId. That's the main problem. If you ask me, it's not a problem, but I don't see a solution, because my library depends on One-Tap API. :)

Also there are quite a few popular apps that request that info manually from a user, immediately after a successful sign in, without any library.

stevdza-san avatar Nov 02 '23 06:11 stevdza-san