Stanislav Terliakov
Stanislav Terliakov
I'm afraid this will break horribly down the road. Any custom `__init__` method is a disaster for this plugin, note how we use its `arg_names` and `arg_types` to get the...
Huh, not exactly, raising a `TypeError` is a bit too harsh: `mypy` reports errors differently, we do not make it crash when a problem is detected in user's code. Look...
I'm not sure I love the idea of returning `AnyType`, that seems a bit arbitrary, but should work at least. Please add relevant testcases - see `test-data/unit/check-plugin-attrs.test` for inspiring examples,...
Ignore the `xarray` diff, we have some recent regression causing nondeterministic results to appear more often, tracked in #19121. The `xarray` diff was reported on even more obviously unrelated PRs,...
The `xarray` issue is moot, while the test failures are real - the changed code does not pass some tests. Either the `__init__` method is somehow **not** `plugin_generated` (which is...
Personally I'm totally swamped right now and won't have any chance to review code outside of my primary work with enough attention for at least a few days. I'm not...
> Should perhaps live in check-python311.test Yes, every test that depends on python version higher than minimal supported version (3.9 now) should live in `check-python*.test` files (matching the minimal version...
> Essentially, the logic should be like this: if we detected that we have actually matched a deprecated overload (in the two places I added), then we should try checking...
https://github.com/user-attachments/assets/478f494f-db33-424c-b9da-e79194a2c422
Hm, the video renders fine on my end now. Perhaps a github glitch? This works for FP numbers no worse than before. Naive implementation (just slapping an `f64` as an...