zed-ros2-wrapper icon indicating copy to clipboard operation
zed-ros2-wrapper copied to clipboard

Published 20 hours ago • verified publisher icon stereolabs

Add support for latest ROS2 versions

Open nakai-omer opened this issue 1 year ago • 4 comments

Fixes #79, which also adds supports for versions Galactic and later. This should be merged into a galactic and humble branches.

nakai-omer avatar Aug 09 '22 21:08 nakai-omer

I will update the readme as well, if this fix is acceptable.

nakai-omer avatar Aug 09 '22 21:08 nakai-omer

Please do not change the file format when pushing a PR. We cannot merge it. Only apply your modifications disabling any kind of auto-formatter

Myzhar avatar Aug 09 '22 21:08 Myzhar

@Myzhar Sorry about that, fixed.

nakai-omer avatar Aug 10 '22 12:08 nakai-omer

Would be interested to see this PR merged in fwiw.

swiz23 avatar Aug 30 '22 20:08 swiz23

Thank you for the fixes. I'm not merging your PR directly, but I'm going to create a ros2_humble branch before.

Myzhar avatar Sep 20 '22 15:09 Myzhar

Thank you for the fixes. I'm not merging your PR directly, but I'm going to create a ros2_humble branch before.

If you would like to follow ros2 conventions, branch name should only be humble https://docs.ros.org/en/foxy/The-ROS2-Project/Contributing/Developer-Guide.html#branches

nakai-omer avatar Sep 21 '22 10:09 nakai-omer

I know, that's only for development. I'm going to merge everything into the master branch to have a package that supports all the current LTS versions (i.e. foxy and humble)

Myzhar avatar Sep 21 '22 11:09 Myzhar

Merged in the ros2_humble branch. Merge into the master branch will follow after QA

Myzhar avatar Sep 21 '22 15:09 Myzhar