zed-ros2-wrapper icon indicating copy to clipboard operation
zed-ros2-wrapper copied to clipboard

Documentation doesn't provide correct git clone command

Open KohlhardtC opened this issue 1 year ago • 1 comments

Preliminary Checks

  • [X] This issue is not a duplicate. Before opening a new issue, please search existing issues.
  • [X] This issue is not a question, feature request, or anything other than a bug report directly related to this project.

Description

The Getting Started with ROS 2 and ZED does not show the correct clone command in the Build the package section. The command is missing the recursive option.

The correct clone command is: git clone --recursive https://github.com/stereolabs/zed-ros2-wrapper.git

On a side note, it might help some new users to remind them to source their ROS2 environment before attempting to run rosdep

Steps to Reproduce

  1. Follow the documentation to build the pacakge

...

Expected Result

The package builds

Actual Result

rosdep and colcon build fails because the recursive option is not in the clone command

ZED Camera model

ZED2i

Environment

Ubuntu 20.04
Jetson Orin AGX
ROS2/Foxy

Anything else?

No response

KohlhardtC avatar Oct 18 '22 15:10 KohlhardtC

Hi @KohlhardtC thank you for reporting

Myzhar avatar Oct 18 '22 15:10 Myzhar

The online documentation is updated now

Myzhar avatar Oct 27 '22 05:10 Myzhar