Steph Locke

What things do you think should be covered in a package review?

11

We can do a lot of different things in a package review. What do you think should be included?

Anyone know if there's a package that trumps Mango's and is ideally on CRAN? https://github.com/mangothecat/functionmap

Add unit tests

5

This package could do with tests - some thought will need to go into managing the account used for testing http://blog.revolutionanalytics.com/2015/12/securely-storing-your-secrets-in-r-code.html http://matthewlincoln.net/2016/05/13/r-packages-secret-keys-and-appveyor.html https://cran.r-project.org/web/packages/googlesheets/vignettes/managing-auth-tokens.html

We need to demonstrate how one can create a hash for a file, store it, and then use if for comparison purposes in our sourcesafe function. https://github.com/ropenscilabs/r-security-practices/blob/master/handouts/02-users.Rmd#unsafe-sourcing

Make this support multiple languages, might need new theme eg https://themes.gohugo.io/hugo-theme-learn/

Since upgrade, Function reading from EventHub batches now reading triple

10

I upgraded my Functions this morning. My Function that reads from a batch usually causes my EventHub outputs to be _double_ the number of inputs. Since this morning that figure...

Bug with firewall provisioning when using OIDC

3

I have created a pipeline ```yml name: PR Environment Preview on: pull_request: types: [opened, synchronize, reopened, edited] permissions: contents: read id-token: write # Needed for Azure login with OIDC env:...

Enabling people to work with authentication and authorisation as part of this would be super helpful - could perhaps be a spin off from this repo.

The [Implicit grant flow](https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-implicit-grant-flow) docs contain the following warning: > Warning > > Microsoft recommends you do not use the implicit grant flow. In most scenarios, more secure alternatives are...