react-flagkit icon indicating copy to clipboard operation
react-flagkit copied to clipboard

Bump terser from 4.8.0 to 4.8.1

Open dependabot[bot] opened this issue 2 years ago β€’ 0 comments

Bumps terser from 4.8.0 to 4.8.1.

Changelog

Sourced from terser's changelog.

v4.8.1 (backport)

  • Security fix for RegExps that should not be evaluated (regexp DDOS)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Jul 22 '22 00:07 dependabot[bot]

Please note that this will break code like this because calls to clone and to_owned will no longer be dereferenced:

#[derive(Debug, Model)]
struct A {
    id: Uuid,
    #[ormlite(join_column = "b")]
    b: Join<B>
}

#[derive(Clone, Debug, Model)]
struct B {
    id: Uuid,
}

fn hi(a: A) {
    // no longer works
    let x: B = a.b.to_owned();
    // now works
    let y: Join<B> = a.b.to_owned();
    // still works
    let z: B = (*a.b).to_owned();
}

nitn3lav avatar Feb 15 '24 20:02 nitn3lav

Can you provide a rationale and example code for why you'd want to Clone a Join struct? My mental model is that it's owned by the queried object, and never lives elsewhere. Definitely happy to include it if it makes sense, just concerned it might also lead to mistakes where users think they're updating the values, but it was only the clone that was updated.

kurtbuilds avatar Feb 15 '24 21:02 kurtbuilds