ashr icon indicating copy to clipboard operation
ashr copied to clipboard

doesn't handle zero sebetahats correctly

Open willwerscheid opened this issue 6 years ago • 4 comments

For example, ash(betahat = c(1, 2, 3, 4), sebetahat = c(0, 0, 1, 1)) gives me posterior means of zero for the first two observations.

willwerscheid avatar Jul 25 '18 14:07 willwerscheid

We might want to handle infinite SEs too, possibly by throwing an error. (We can get infinite SEs in flash.)

willwerscheid avatar Jul 25 '18 14:07 willwerscheid

calc_pm automatically sets these cases (covered by get_exclusions) to have a mean of zero and a SD of zero. We should change this: zero SEs should return mean = x, sd = 0; infinite SEs and NAs should return prior mean and sd.

willwerscheid avatar Jan 30 '19 17:01 willwerscheid

Issue #59 can be addressed as part of the same fix.

willwerscheid avatar Jan 30 '19 17:01 willwerscheid

Infinite SEs also screw up the returned log likelihood.

willwerscheid avatar Jun 26 '19 16:06 willwerscheid