liballocs icon indicating copy to clipboard operation
liballocs copied to clipboard

allocscompilerwrapper.py puts defsyms too late when wrapping in-exe malloc

Open stephenrkell opened this issue 3 years ago • 2 comments

The malloc-in-exe test case hacks around this with its own LDFLAGS in mk.inc. But without these, the __wrap___real_malloc and friends are being defined (in liballocs_nonshared.a) too early on the command line to be picked up by the defsym options which want to bind to them.

stephenrkell avatar Apr 08 '22 14:04 stephenrkell

I meant to say 'defined too late', of course (or referenced too early).

stephenrkell avatar Apr 08 '22 15:04 stephenrkell

This got tweaked in 9a7a29c since the CircleCI box had different linker version/behaviour. We needed to split the defsyms up from the -lallocs (to keep the latter towards the end of the command line), making the compiler wrapper Python script even more nasty.

stephenrkell avatar Jul 08 '22 14:07 stephenrkell

This was fixed in 0ed8eafd.

stephenrkell avatar Oct 04 '22 16:10 stephenrkell