Stephen Papierski

Results 13 comments of Stephen Papierski

There are a few places I'm not a fan of what it does, but overall I am a fan of some kind of coding style being enforced. My vote would...

Looks like the supported keys in hacs.json changed, so I had to remove domains and iot_class from hacs.json to get it to pass the checks.

Looks like the NumberEntity was refactored, and we need to update the properties we're setting to match the new setup. Doesn't look like too hard of a fix. [Blog post...

If I'm reading the above correctly, a new solution needs to be coded that has an option similar to the resend up/down notifications? ![image](https://github.com/louislam/uptime-kuma/assets/5900005/de6196c1-9f72-4ba3-b460-23aec8982107) Something like `Resend Notification if Slow...

Am I supposed to leave this as a draft during discussion, or move it to `Ready to review`?

Ok, just wanted to make sure I didn't need to move to `Ready for review` to signal that it is in fact ready for review.

I would agree if the guidelines didn't stop where they do. ![image](https://github.com/louislam/uptime-kuma/assets/5900005/121786aa-605e-45b2-b1b5-71664cdbc222) I'll go ahead and move it to `Ready for review` and submit another pull request with a proposed...

Do we think the defaults are ok? I've gone back and forth on a couple items - Calculating the response time by averaging the last 5 minutes - My thought...

Are there any additional setup steps required for the Unraid container (anything with .env or additional parameters)? Mine installs and starts up fine, but does not take me to the...

Based on the docker-compose, it looks like you need the `librephotos-proxy`, `postgres`, `librephotos-frontend`, and `librephotos` containers for it all to work. @derneuere is the `singleton` container still active? Or should...