drum icon indicating copy to clipboard operation
drum copied to clipboard

Tests

Open j7nn7k opened this issue 9 years ago • 5 comments

The docs mention tests. Are there any? If not, do you have any preferred testing framework?

j7nn7k avatar Dec 30 '15 23:12 j7nn7k

Guess there are none at this point ;)

j7nn7k avatar Oct 30 '16 09:10 j7nn7k

Would you like to add some?

stephenmcd avatar Oct 30 '16 23:10 stephenmcd

Why not

j7nn7k avatar Oct 31 '16 04:10 j7nn7k

@stephenmcd I added some tests. Unfortunately I can't make a pull request from a drum fork because I already maintain a drum fork, which is not fully compatible anymore with the original drum project.

Is there a chance I can push my branch to the original project? Of course in a separate branch!

Thanks Jannik

j7nn7k avatar Oct 31 '16 06:10 j7nn7k

If you create a branch in your fork that doesn't include your changes, merge this repo's master into it, and add tests there, you should be able to create a valid PR.

stephenmcd avatar Oct 31 '16 23:10 stephenmcd