stephenmcd

Results 128 comments of stephenmcd

Could you create a pull request with the fix? Thanks

Thanks for this, it definitely needs fixing but I think a much simpler approach would be to just use the default storage engine configured. Would you like to look at...

Yeah but now there's 3 options instead of 1, seems like overkill.

Also I just realised on reviewing this a bit further - the whole idea of FORMS_BUILDER_UPLOAD_ROOT and using filesystem storage is to protect the files from being publicly accessible, so...

You're right. So I guess the approach is on the right track, it probably needs a bit more work though. We should probably have one location in the code that...

Also some work to be done in https://github.com/stephenmcd/django-forms-builder/blob/master/forms_builder/forms/admin.py#L187 where (if I recall) admin users can download uploaded files from links with emails they're sent.

Can you provide the code needed to reproduce your example?

Thanks for adding the issue. The bundled socket.io JavaScript is tied to the server implementation in the public release of gevent-socketio: https://bitbucket.org/Jeffrey/gevent-socketio It looks like the version in that repo...

Tony that's awesome! I'll check it out soon and hopefully at some point I can merge it all back in.

Just an update on this - I've pulled the latest work from https://github.com/tgcondor/django-socketio and I'm currently in the process of getting everything working for a new release for the latest...