Results 593 comments of Stephen Haberman

I'm a little worried about the assumption that protobufjs would always use a `BufferWriter`, but if you're 100% sure / that is what their return types / docs say anyway,...

Hi @Frabat ; sure if you wanted to modify the existing `outputEncodeMethods` to support values like: ``` outputEncodeMethods = true | false | "encode-only" | "decode-only" ``` I think that'd...

Ah yeah, that looks interesting. I'm not surprised this doesn't work/overlaps. Honestly I'm not sure/don't remember what the canonical proto3 JSON encoding of your schema would be. Do you know?...

Ah yeah, @wsp-repo I think you can make a fork of `stephenh/ts-proto` with github, and push to your fork, then make a pull request from there.

Hey @jeremysf ; apologies for the late reply. I've not used ts-proto in a mono repo, but yeah that makes sense, I believe I understand the issue you're having. Just...

> There is not a common node modules directory to hoist to Ah, okay, the smaller "mono"-but-not-really-mono repos I've worked in have always had that. If you want to submit...

Hey @vimmerru , happy to review PRs if you have concrete suggestions for a specific `outputServices` mode. Fwiw I wrote the original `outputServices=default` for Twirp ~4 years ago, and the...

Ah yeah... It's been awhile since I've used the `context=true` param, but if I were going to use it again, I'd very likely change it to something like `--ts_proto_opt=context=Context@src/context.ts` or...

Huh, I'm kinda surprised, but yeah I guess we don't have an option for that. If you'd like to work on a PR for `useWrapperTypes=true/false`, that'd be great. Thanks!

Ah yeah, another ts-proto user found this fix, using the protobufjs `wrappers` to teach it about ts-protos custom types: https://github.com/stephenh/ts-proto/pull/567/files#diff-03dbad58cc98518642d755fb4f33bafe8498ed71b1b17e9880e7b1a4c15a3598R30 So if you have `nestJs=true` on, then `Timestamp`s should have...