Results 593 comments of Stephen Haberman

@onpaws no, didn't bother starting a PR w/o an ack from the maintainers. Plus our existing codebase already has the per-file snippet so this is a nice to have, but...

You've got `outputServices` twice in your config param, so it ends up being: ``` "outputServices": Array [ "grpc-js", false, ], ``` Just remove the `outputServices=grpc-js` since you don't want them?

Oh, I see, `outputServices=grpc-js` calls this: ``` export function generateGrpcJsService( ctx: Context, fileDesc: FileDescriptorProto, sourceInfo: SourceInfo, serviceDesc: ServiceDescriptorProto ): Code { const { options } = ctx; const chunks: Code[]...

> so outputServices=grpc-js should not generate client code by default I think in retrospect, yes, but we probably have to keep current behavior to avoid a breaking change. So like...

Hi @tufandevrim this seems pretty reasonable, see the one question about repeateds, but otherwise this lgtm!

@tufandevrim looks like a minor prettier error in `main.ts`; can you fix it up? Thanks!

:tada: This PR is included in version 1.170.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/ts-proto/v/1.170.0) - [GitHub release](https://github.com/stephenh/ts-proto/releases/tag/v1.170.0) - `v1.170.0` Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

Hi @Demon000 , proto2 should be supported; it was not an initial goal of ts-proto, but I think it basically works at the moment. The biggest flag for proto2 support...

> The second issue I have is that fields with set default values will not be sent over the wire. Ah, okay, that makes sense. I think the only place...