Stephen Finucane
Stephen Finucane
Those are all proxy APIs. I'd be inclined *not* to delete any of these where the code still exists behind an older microversion, but I have no issues deleting those...
tl;dr: we want to delete `defsecrules`. More info below. - `defsecrules` This has been removed entirely from nova as it was related to nova-network and should be deleted here also....
@mandre Assuming you agree with my logic, can we merge this as-is and I'll propose a follow-up to drop the `defsecrules` code?
> > some people still use these since they can be seen as "easier" to use that the proper APIs. While we removed the code for those APIs from novaclient...
> Thanks for investigating @stephenfin. I'd personally be in favor of deleting the deprecated extensions from gophecloud v2 and redirect users who still rely on these old APIs to build...
> That's a really good idea, thanks for working on this. I've dropped some comments. I also want @pierreprinetti's feedback on the structure (unit vs lint, what to run) etc....
> > Our CI jobs run make instead of calling scripts. > > This wasn't addressed, what's the plan? I plan to address this separately once #3005 is merged. We...
> I plan to address this separately once #3005 is merged. We can't do it sooner than that as we need to manually specify skips and that's not easily possible...
Note that I didn't set the `--base v2` option when submitting this so it's merging into `master`. If this is indeed supposed to be merged into `v2`, I'd ask that...
> I personally prefer the first approach: the one where the scheduler hints are conflated into the existing `createOpts`. My rationale for that is: `createOptsBuilder` is an interface that outputs...