ghi icon indicating copy to clipboard operation
ghi copied to clipboard

warning: URI.escape is obsolete

Open jeromefaria opened this issue 6 years ago • 6 comments

Hello! I am getting this error whenever I edit an issue/PR. It appears to still work but I never noticed this warning before.

/usr/local/Cellar/ghi/1.2.0_4/libexec/bin/ghi:1305: warning: URI.escape is obsolete
/usr/local/Cellar/ghi/1.2.0_4/libexec/bin/ghi:1305: warning: URI.escape is obsolete

ghi version 1.2.0 Mac OS X 10.15.3 19D76

By the way, thank you for this great tool! 🍻

jeromefaria avatar Jan 31 '20 08:01 jeromefaria

Seeing the same message, it would be great to have a fix. Thanks!

suzdalnitski avatar Mar 23 '20 16:03 suzdalnitski

This blog post suggests some alternative methods for URI.escape

https://docs.knapsackpro.com/2020/uri-escape-is-obsolete-percent-encoding-your-query-string

vielmetti avatar Apr 23 '20 02:04 vielmetti

Seems to be addressed by PR #386.

xtaran avatar Apr 27 '20 00:04 xtaran

I'm still getting the error using the version on Master now

curl -sL https://raw.githubusercontent.com/stephencelis/ghi/master/ghi > ghi ...

holtzermann17 avatar Nov 17 '20 18:11 holtzermann17

Still getting the error…

PhilippePerret avatar Jun 09 '21 08:06 PhilippePerret

#386 was closed but not merged

fpereira1 avatar Jun 22 '21 02:06 fpereira1