SQLite.swift icon indicating copy to clipboard operation
SQLite.swift copied to clipboard
verified publisher icon stephencelis

Added Sendability conformance

Open samdogg7 opened this issue 4 months ago • 3 comments

Added Sendability conformance, where I could without modifying underlying code.

  • [x] Run make lint to check if there are any format errors (install swiftlint first)
  • [x] Run swift test to see if the tests pass.
  • [x] Write new tests for new functionality.
  • [x] Update documentation comments where applicable.

samdogg7 avatar Aug 27 '25 23:08 samdogg7

@nathanfallet I am wrapping SQLite.swift in my own module that I'd like to migrate over to Strict Concurrency. In my case, I particularly would like to mark Expression as Sendable. I added in a variety of Sendable conformances across the repository that didn't require changes to the underlying code. Larger coverage would be beneficial, but I think can be done iteratively.

samdogg7 avatar Aug 28 '25 14:08 samdogg7

@nathanfallet tests are failing due to iOS 18.0 being set as the version, looks like we only have 18.4 / 18.5 installed

samdogg7 avatar Sep 04 '25 18:09 samdogg7

Try updating your branch with the main one. We handled this issue in a recently merged PR.

nathanfallet avatar Sep 04 '25 20:09 nathanfallet