glaze icon indicating copy to clipboard operation
glaze copied to clipboard

Templated http_router for broader reuse and using boost-ext/ut instead of openalgz/ut

Open arun5309 opened this issue 5 months ago • 2 comments

I have made http_router more generic by templating the handler type to address issue #1873.

But I had to use boost-ext/ut instead of openalgz/ut as the latter lacked support for parameterized tests to make testing it easier.

I will clean up the commits and possibly move back to openalgz/ut depending on your feedback.

arun5309 avatar Sep 16 '25 03:09 arun5309

@arun5309, this look excellent! Yeah, I should add parameterized tests to openalgz/ut. The reason we can't use boost-ext/ut is that there are critical multi-threading bugs that cause programs to crash by simply including boost-ext/ut: https://github.com/boost-ext/ut/issues/618

stephenberry avatar Sep 16 '25 13:09 stephenberry

One thing I forgot to mention is that std::move_only_function did not work as a handler (type) that is why I created alt_handler type. Looking into if the handler type needs to be copyable might be of interest.

arun5309 avatar Sep 21 '25 14:09 arun5309

Based on this pull request I implemented this in #2151. So, we can close this now. Thanks for contributing this approach and idea!

stephenberry avatar Dec 18 '25 02:12 stephenberry