node-notes icon indicating copy to clipboard operation
node-notes copied to clipboard

Notes.filterDirectories not filtering directories passed in.

Open Duder-onomy opened this issue 11 years ago • 1 comments

Hello. Thanks for the awesome addition to node! This feature was awesome in rails, will be just as useful in node apps.

The filter directories array defined on line 32 of notes.js does not filter directories added to it.

Maybe I am not understanding your intention, but should this not skip the directories listed?

Notes.filterDirectories = ["node_modules", "app/vendor", "build"];

Notes does not skip the app/vendor or build directories.

Thanks Greg

Duder-onomy avatar Sep 11 '13 19:09 Duder-onomy

@Duder-onomy i have just published a similar module with this issue fixed on https://github.com/ahmadassaf/code-notes

ahmadassaf avatar Feb 26 '17 15:02 ahmadassaf