robospice
robospice copied to clipboard
stephanenicolas
Own implementation of RequestRunner
Hi, I need to replace DefaultRequestRunner to own. But as I see SpiceService.createRequestRunner() now is private method. Is it possible to make it protected?
That would be easy enough to do and I doubt anyone would complain. Although you should probably make it protected as opposed to public since you'll only use it in your own spice service.
On 17 February 2015 19:50:26 GMT+00:00, Igor Zubenko [email protected] wrote:
Hi, I need to replace DefaultRequestRunner to own. But as I see SpiceService.createRequestRunner() now is private method. Is it possible to make it protected?
Reply to this email directly or view it on GitHub: https://github.com/stephanenicolas/robospice/issues/406
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Just realised you said protected already so never mind :-)
Just submit a commit with your changes and someone will be right with you!
On 17 February 2015 20:12:48 GMT+00:00, Andrew Clark [email protected] wrote:
That would be easy enough to do and I doubt anyone would complain. Although you should probably make it protected as opposed to public since you'll only use it in your own spice service.
On 17 February 2015 19:50:26 GMT+00:00, Igor Zubenko [email protected] wrote:
Hi, I need to replace DefaultRequestRunner to own. But as I see SpiceService.createRequestRunner() now is private method. Is it possible to make it protected?
Reply to this email directly or view it on GitHub: https://github.com/stephanenicolas/robospice/issues/406
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Sent from my Android device with K-9 Mail. Please excuse my brevity.
I'm just pleased to see the modular approach to robospice is seeing a lot more usages.
On 17 February 2015 20:14:33 GMT+00:00, Andrew Clark [email protected] wrote:
Just realised you said protected already so never mind :-)
Just submit a commit with your changes and someone will be right with you!
On 17 February 2015 20:12:48 GMT+00:00, Andrew Clark [email protected] wrote:
That would be easy enough to do and I doubt anyone would complain. Although you should probably make it protected as opposed to public since you'll only use it in your own spice service.
On 17 February 2015 19:50:26 GMT+00:00, Igor Zubenko [email protected] wrote:
Hi, I need to replace DefaultRequestRunner to own. But as I see SpiceService.createRequestRunner() now is private method. Is it possible to make it protected?
Reply to this email directly or view it on GitHub: https://github.com/stephanenicolas/robospice/issues/406
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Thanks for your answer. I will try to create pull request. But I never do it before. :)
My first time was a learning curve too.
Check out GitHub starter guide for details.
It's well worth it!
On 17 February 2015 20:30:42 GMT+00:00, Igor Zubenko [email protected] wrote:
Thanks for your answer. I will try to create pull request. But I never do it before. :)
Reply to this email directly or view it on GitHub: https://github.com/stephanenicolas/robospice/issues/406#issuecomment-74746832
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Yep, I'm already understood how to do it. But I have one more question. In what branch I can commit?
Best way is to create a new branch from master.
Then submit that for pull request. That way you can make more branches from master with different pull requests
On 17 February 2015 20:41:32 GMT+00:00, Igor Zubenko [email protected] wrote:
Yep, I'm already understood how to do it. But I have one more question. In what branch I can commit?
Reply to this email directly or view it on GitHub: https://github.com/stephanenicolas/robospice/issues/406#issuecomment-74748877
Sent from my Android device with K-9 Mail. Please excuse my brevity.