stephane
modbus default port is 502
The system was previously configured to use port 1502 as a hard-coded value. However, I recommend updating this to port 502, which is the standard default port for Modbus communication, as specified by industry guidelines.
For further reference, please see Cisco's Modbus configuration documentation: https://www.cisco.com/c/en/us/td/docs/switches/connectedgrid/cgs2520/software/release/12_2_53_ex/configuration/guide/scg2520/swmodbus.pdf
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi Stephane,
Thank you for replying so quickly.
I really appreciate it and understand the reason why the test uses 1502 port..! Yeah it is reasonable !
I’m making PV Invertor charger and sub-station(metering PV Invertor) using Modbus unit-server-test.c file..! I hope to contribute my code after I finish to implement this!
Thank you.
Have a nice weekend.
Best Regards, Kay
On Sat, Sep 28, 2024 at 2:23 AM Michael Heimpold @.***> wrote:
@.**** requested changes on this pull request.
I'm fine with the part which changes the documentation, but leave alone the test stuff. Port 502 is a privileged one on Linux systems, that means that only root can bind to it. So this would prevent usual users to run the tests without using sudo or other means.
— Reply to this email directly, view it on GitHub https://github.com/stephane/libmodbus/pull/771#pullrequestreview-2334975487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFH2EE2TFDCNCP3AYEVBCLZYZYRJAVCNFSM6AAAAABO7ZZMZGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZUHE3TKNBYG4 . You are receiving this because you authored the thread.Message ID: @.***>
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...
Kay, I think you mix two different tasks here: This PR initially suggested to rewrite code in this libmodbus repo. The proposed change in the documentation is reasonable and should be merged. Please update this PR in that you put a single commit in this existing branch which does exactly the mentioned change. Not more - not less. Then this PR can be merged after all formal issues are solved (CLA signed, commits with SoB, proper patch description etc.). I really encourage to go forward here.
The other point/task is your own PV inverter application. It just uses libmodbus. But it should not be part of this repo. I recommend to share it in a dedicated repo here on Github. This design keeps a clear barrier between library and application code. Please consider moving on this way.
