libmodbus icon indicating copy to clipboard operation
libmodbus copied to clipboard

adding get_query_function

Open cedricboudinet opened this issue 2 years ago • 6 comments

Hello Here is a PR adding a function enabling one to read the modbus function of a query. It can be useful for modbus server development. If you are ok with it I can complete the docs as well. Bests Cedric

cedricboudinet avatar Nov 10 '22 14:11 cedricboudinet

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Cedric Boudinet. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Nov 10 '22 14:11 cla-bot[bot]

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Nov 10 '22 14:11 cla-bot[bot]

Usually open source development works that way, that you create a full PR, i.e. including documentation etc. In your documentation, I would for example expect to find a description of your use case for this new function - at the moment, you only described it roughly.

mhei avatar Nov 11 '22 16:11 mhei

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Nov 15 '22 20:11 cla-bot[bot]

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Nov 15 '22 20:11 cla-bot[bot]

Dear @stephane Could this PR be merged as well? Bests Cedric

cedricboudinet avatar Jul 22 '24 07:07 cedricboudinet