libmodbus icon indicating copy to clipboard operation
libmodbus copied to clipboard

Catch some buildsystem errors

Open ndim opened this issue 3 years ago • 1 comments

This catches some errors which can happen in the build system:

  • If autoreconf fails for some reason (exit with code != 0), there is no good reason for the autogen.sh script to succeed.(exit with code 0).

  • If the system does not have libtool installed, the LT_INIT m4 macro is not available and therefore the configure script cannot be generated properly. This should result in autoreconf aborting with an error, and not in the configure script containing a line of verbatim LT_INIT([disable-static win32-dll pic-only]). m4_pattern_forbid provides just that.

JFTR, I stumbled upon this due to https://stackoverflow.com/questions/73355119/error-libtool-library-used-but-libtool-is-undefined-but-libtool-installed-on.

ndim avatar Sep 07 '22 19:09 ndim

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Sep 07 '22 19:09 cla-bot[bot]

Thank you @ndim. No need CLA for minor changes (even more when there are not in source code). Merged.

stephane avatar Oct 03 '22 20:10 stephane