libmodbus icon indicating copy to clipboard operation
libmodbus copied to clipboard

Added modbus encapsulated in TCP support.

Open henrikmakitaavola opened this issue 9 years ago • 3 comments

henrikmakitaavola avatar Nov 25 '16 11:11 henrikmakitaavola

Saw this just now: Added feature RTU over TCP #260 opened on Apr 28, 2015 by xabies
Believes this implements the same feature..

henrikmakitaavola avatar Nov 25 '16 14:11 henrikmakitaavola

This patch duplicates code and duplicated code is not maintainable :/

stephane avatar Nov 28 '16 13:11 stephane

Yeah, I guess you mean the crc tables etc. Apart from that, would this be a suitable solution to implement encasulated modbus over tcp? Could fix the duplicated code if you see any use of this.

henrikmakitaavola avatar Nov 28 '16 16:11 henrikmakitaavola