plugins icon indicating copy to clipboard operation
plugins copied to clipboard

GHC 9.2 support is missing

Open Kleidukos opened this issue 2 years ago • 5 comments

Hi! I'd like to start using plugins for an application of my own.

I tried to depend on it with GHC 9.2 as my compiler, and the following message makes me think that plugins is still trying to look up the old module hierarchy:

src/System/Plugins/LoadTypes.hs:33:1: error:
    Could not find module ‘HscTypes’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
33 | import HscTypes
   | ^^^^^^^^^^^^^^^

You're probably busy, so would you accept a PR to fix this?

Kleidukos avatar Sep 14 '22 19:09 Kleidukos

Yes. In fact, accepting PRs and uploading a new version to hackage is the only work I do on this package.

stepcut avatar Sep 14 '22 21:09 stepcut

Got it! Thanks for being reactive. :)

Kleidukos avatar Sep 14 '22 21:09 Kleidukos

@stepcut Hi! @cgibbard and I have ported the package to the latest GHC releases. Due to the copious amount of CPP involved for (what are frankly ancient) versions of GHC, I wanted your permission to switch the support window to GHC 8.10 minimum. What do you think of this?

Kleidukos avatar Sep 18 '22 22:09 Kleidukos

Given the limited number of users of this package, GHC 8.10 sounds reasonable. If someone really needs to use an older compiler, they can just use an older version of the plugin. I say that as someone who is still using GHC 8.6.5 :)

stepcut avatar Sep 23 '22 12:09 stepcut

I'm still getting this error with ghc 9.0.2, has anyone figured out a fix?

bleedsa avatar Mar 02 '24 17:03 bleedsa