stepancheg
Add support for `reserved` keyword in enums.
The reserved keyword was supported for messages but not for enums. Also used this opportunity to remove the FieldNumberRange type and use RangeInclusive instead, as proposed by a TODO comment in the existing code.
Closes #671
Hi @rizlas, nice to see someone using this. :) Just FYI I will be quite limited in helping out to get this merged as I have not touched any perl since 2017 and currently delve in infrastructure so I no longer have any access to any testing environment(s). Would be great if it could be merged though with your (or RT's) help as I still consider RT to be one of the best ticket-trackers there is and it's sad to keep this out of master/stable.
Hi, yeah it is really helpful for remote user based auth. I've never written perl till today, I just tweaked your original PR 🤣
I didn't include the utf8 fix that I read in your dockerization (https://github.com/SUNET/docker-rt-swamid/blob/master/Web.pm.patch#L47). However, in the absence of an equivalent function, I believe that that should be added too.
You do need it unless you expect only strict ascii-users (which never happens, there's always some random chars in names). :) Names will misbehave unless you keep the utf8-line.
(which never happens, there's always some random chars in names)
Yeah, that's why for me it should be included 😆 But maybe there is already a helper function that does utf8 conversion.