secure-repo
secure-repo copied to clipboard
Add KBs for actions
Fixes #748 Fixes #753 Fixes #762 Fixes #792 Fixes #809 Fixes #810 Fixes #812
Codecov Report
Merging #1133 (729c1ab) into main (c0c8c26) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 13 13
Lines 1266 1266
=======================================
Hits 738 738
Misses 468 468
Partials 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Thanks @RksRocks for the PR!
Few things to note:
- The PR title should typically be
Add KBs for Actions
in this case. - Please limit KBs to 5 per PR, else it gets hard to review in one go.
@Devils-Knight please confirm once you have reviewed these changes?
Ok, will consider the mistakes/suggestions.
Thank you
On Sat, 10 Sep, 2022, 9:42 pm Varun Sharma, @.***> wrote:
Thanks @RksRocks https://github.com/RksRocks for the PR!
Few things to note:
- The PR title should typically be Add KBs for Actions in this case.
- Please limit KBs to 5 per PR, else it gets hard to review in one go.
@Devils-Knight https://github.com/Devils-Knight please confirm once you have reviewed these changes?
— Reply to this email directly, view it on GitHub https://github.com/step-security/secure-workflows/pull/1133#issuecomment-1242760941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWZRZSQG4Q4METTFZABUEFTV5SXODANCNFSM6AAAAAAQG6QGUM . You are receiving this because you were mentioned.Message ID: @.***>
@RksRocks please also add knowledge-base/actions/tomwillis608/detect-secrets-action/action-security.yml
this file back.
create new file with same name and copy the contents.
@varunsh-coder you can review the PR now
Also look into a minor issue that I have commented on this KB. artiomtr/jest-coverage-report-action/action-security.yml