reactcards icon indicating copy to clipboard operation
reactcards copied to clipboard

Published 20 hours ago • verified publisher icon steos

Consider Iframe for rendering basic cards.

Open jhicken opened this issue 8 years ago • 6 comments

If your component has a position fixed style. Things are ungood. If we Iframe it up we should be able to dodge that bullet.

Thoughts?

jhicken avatar May 24 '16 14:05 jhicken

Sounds good.

busypeoples avatar May 24 '16 15:05 busypeoples

@jhicken want to give it a try?

busypeoples avatar May 29 '16 21:05 busypeoples

#13

There you go have a peek.

Sorry I have been aloof I want to contribute with a few more things but Im busy as of late.

jhicken avatar May 30 '16 04:05 jhicken

@jhicken Thanks! @steos what do you think?

busypeoples avatar May 30 '16 09:05 busypeoples

@jhicken thanks for your work! Looks good to me, but I get a strange warning with those changes:

Warning: exception thrown by devtool while handling onSetChildren: Expected onMountComponent() to fire for the child before its parent includes it in onSetChildren().

Not sure what's the issue here, any ideas?

steos avatar May 30 '16 10:05 steos

I dug into it a bit yesterday. I didn't find the cause. But I know that the test cards cause the error on first render. Also the stateful card changes make it happen. I have a guess that its related to something happening durring the translation in react-frame-component but not totally sure yet.

jhicken avatar Jun 01 '16 15:06 jhicken