mu icon indicating copy to clipboard operation
mu copied to clipboard

Support additional containers per task definition

Open cplee opened this issue 7 years ago • 8 comments

Need to be able to specify sidecar containers for things like monitoring agents that run in the same task, but as a separate container.

cplee avatar Mar 19 '18 17:03 cplee

I'm looking at picking this up, do you have anything in mind for what the interface/mu.yml would look like for this case? E.g. being able to specify docker images for additional containers?

zsims avatar Nov 01 '18 05:11 zsims

@zsims thinking something like this:

service:
  sidecars:
    imageRepository: my/image
    cpu: 20
    memory: 400
    environment:
      FOO: bar

cplee avatar Nov 01 '18 15:11 cplee

Awesome, would you see that mu could also build the sidecars? E.g. from a Dockerfile in the repo? Or perhaps that's something to be tackled later?

zsims avatar Nov 01 '18 22:11 zsims

hmm, good question. i was thinking of stuff like datadog/agent or buoyantio/linkerd as a sidecar. maybe just stick with that for now and if needed we can look for support on building sidecars at a future time

cplee avatar Nov 01 '18 22:11 cplee

Makes sense, I'll have a crack! Thanks for the details

zsims avatar Nov 01 '18 23:11 zsims

As there can be 0 or more sidecars, is the preference to use the template syntax to generate additional containers in the CFN template? E.g. https://github.com/stelligent/mu/blob/e54bb6792e9c760f18226ddc55c2acedf8f87fb7/templates/assets/cloudformation/service-ecs.yml#L352

zsims avatar Nov 03 '18 08:11 zsims

Yep, that sounds right to me @zsims

cplee avatar Nov 04 '18 00:11 cplee

+1 for this feature. @zsims have you had a chance to work on it?

AndreyMarchuk avatar Nov 26 '18 21:11 AndreyMarchuk