mu icon indicating copy to clipboard operation
mu copied to clipboard

Improve matching of `Dockerfile` in `.dockerignore`

Open cplee opened this issue 7 years ago • 4 comments

Allow paths like Dockerfile in .dockerignore to match paths like ./Dockerfile that are passed in as the docker build context.

https://github.com/stelligent/mu/blob/develop/common/docker.go#L103-L104

cplee avatar Mar 13 '18 19:03 cplee

@cplee Can you explain this a bit more? I would like to work on this issue.

shubhambhattar avatar Oct 06 '18 21:10 shubhambhattar

@shubhambhattar the problem was that if someone adds the string ./Dockerfile to their .dockerignore file, then running mu svc push will fail since the Docker daemon doesn't receive the Dockerfile in its context.

The goal is that the Dockerfile and the .dockerignore should ALWAYS be included in the archive that is sent to Docker daemon.

cplee avatar Oct 08 '18 05:10 cplee

I'd like to have a crack at figuring this out, still looking for help?

jdbohrman avatar Dec 23 '18 11:12 jdbohrman

@jdbohrman yes please!

cplee avatar Dec 26 '18 17:12 cplee