stellar-core icon indicating copy to clipboard operation
stellar-core copied to clipboard

Published 20 hours ago • verified publisher icon stellar

Enable checkStellarCoreMajorVersionProtocolIdentity check

Open sisuresh opened this issue 1 year ago • 2 comments

The checkStellarCoreMajorVersionProtocolIdentity check here was commented out in https://github.com/stellar/stellar-core/pull/3808, but needs to be re-enabled in a way that works.

sisuresh avatar Jul 05 '23 18:07 sisuresh

would that check never work for vnext? Like when we release 20.0, vnext will want to have a protocol version that is 21

MonsieurNicolas avatar Jul 08 '23 00:07 MonsieurNicolas

Yeah the check as-is is not what we want. This issue is about re-enabling the check in a way that works, or making sure it can stay removed.

sisuresh avatar Jul 08 '23 00:07 sisuresh