soroban-cli icon indicating copy to clipboard operation
soroban-cli copied to clipboard

Support adding a new ledger identity to the CLI

Open elizabethengelman opened this issue 9 months ago • 4 comments
trafficstars

Currently there is not a way to add a key to the CLI config that uses a ledger device as a signer. There is still a way to sign a tx with the ledger - just pass --sign-with-ledger when signing. Do we also want to add a convenience of allowing a user to add a new key to the config that uses a ledger as a signer?

stellar keys add my-ledger-key --ledger-device

This could be similar to how we have stellar keys add my-key --secure-store which allows for adding a key to the config that has its secret stored in the OS's secure storage.

elizabethengelman avatar Feb 19 '25 22:02 elizabethengelman

+1 it should be possible to reference the public key at least. I wonder if there's value in us grouping hardware integrations under a --hardware option, instead of making new options for each one. E.g. --hardware=ledger.

Or --device=.

leighmcculloch avatar Feb 20 '25 03:02 leighmcculloch

This issue is stale because it has been assigned for 30 days with no activity. It will be closed in 90 days unless the stale label is removed, and the assignee is removed or updated.

github-actions[bot] avatar Apr 26 '25 18:04 github-actions[bot]

This issue is stale because it has been assigned for 30 days with no activity. It will be closed in 90 days unless the stale label is removed, and the assignee is removed or updated.

github-actions[bot] avatar Jun 18 '25 18:06 github-actions[bot]

This issue is stale because it has been assigned for 90 days with no activity.

github-actions[bot] avatar Sep 28 '25 18:09 github-actions[bot]