soroban-cli icon indicating copy to clipboard operation
soroban-cli copied to clipboard

Published 20 hours ago • verified publisher icon stellar

Drop `--rpc-url` and `--network-passphrase`.

Open fnando opened this issue 1 year ago • 2 comments

What

Close #1610

Why

To simplify our codebase and improve the CLI usability by having only one way of setting the network.

Known limitations

N/A

fnando avatar Sep 18 '24 22:09 fnando

@leighmcculloch only soroban e2e tests are failing. I believe this requires changing https://github.com/stellar/system-test, right? What's the process? First I update stellar/system-test then merge this, or is it the other way around?

fnando avatar Sep 19 '24 01:09 fnando

@leighmcculloch only soroban e2e tests are failing. I believe this requires changing stellar/system-test, right? What's the process? First I update stellar/system-test then merge this, or is it the other way around?

We don't have a process. We haven't broken it much. 🫢

leighmcculloch avatar Sep 19 '24 03:09 leighmcculloch