soroban-cli icon indicating copy to clipboard operation
soroban-cli copied to clipboard

Sign with system keychain

Open janewang opened this issue 1 year ago • 4 comments

What problem does your feature solve?

Allows users to use accounts not stored by the CLI.

What would you like to see?

Keychain - For macos: https://github.com/near/near-cli-rs/blob/9ef098edcb2eca131592feb4917f3715dceb36a2/src/transaction_signature_options/sign_with_macos_keychain/mod.rs

janewang avatar Jul 23 '24 21:07 janewang

What's the equivalent on Windows? This issue is probably only meaningfully impactful if we address keychain-like capability across multiple platforms because plenty of developers are using windows.

leighmcculloch avatar Jul 24 '24 03:07 leighmcculloch

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, my name is Bernal, and I’m a software developer with four years of experience. I’m passionate about contributing to projects and learn, and I would love the opportunity to contribute to this project

How I plan on tackling this issue

The first step is to understand the project and how it works. Once I have a good understanding of it, I’ll propose a solution to the issue. After that, I’ll implement the solution and run some tests to ensure everything works correctly.

BernalHQ avatar Sep 26 '24 07:09 BernalHQ

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

have a strong background in JavaScript, TypeScript, and Go, working with secure key management in various projects. I’ve integrated system keychains and external authentication methods, ensuring seamless user experiences with enhanced security.

How I plan on tackling this issue

I would first explore the macOS keychain integration using the linked Rust code as a reference. Then, I would design an abstraction layer that securely interacts with the system’s keychain, ensuring compatibility with JavaScript, TypeScript, and Go, allowing users to sign transactions without storing sensitive keys in the CLI.

gregemax avatar Sep 27 '24 05:09 gregemax

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have experience in JavaScript and TypeScript, with a focus on CLI development and integration with system features. I understand the importance of enhancing user account management and security.

How I plan on tackling this issue

I’d review the existing signing implementation and integrate the macOS keychain functionality as outlined in the provided link. This would involve adapting the code to ensure secure access to accounts not stored by the CLI, while maintaining usability for users.

Luluameh avatar Sep 28 '24 00:09 Luluameh

Hi @janewang , can I work on this please?

od-hunter avatar Oct 09 '24 21:10 od-hunter

Removing ODHack8 as the current batch wrapped up

janewang avatar Oct 10 '24 16:10 janewang

Removing ODHack8 as the current batch wrapped up

So can I work on this please?

od-hunter avatar Oct 10 '24 17:10 od-hunter

@elizabethengelman has more capacity to take on this work

janewang avatar Nov 05 '24 19:11 janewang

  • [x] stellar keys generate --keychain --no-fund
  • [x] stellar keys generate --keychain --fund
  • [x] stellar keys address
  • [x] stellar keys fund
  • [x] stellar keys rm
  • [x] stellar keys add
  • [x] stellar keys show
  • [x] stellar tx sign

elizabethengelman avatar Nov 20 '24 20:11 elizabethengelman