soroban-cli icon indicating copy to clipboard operation
soroban-cli copied to clipboard

feat: txn commands to sign, simulate, and send txns

Open willemneal opened this issue 10 months ago • 1 comments

Part of https://github.com/stellar/soroban-cli/issues/1265 Adds

  • txn send - sends a signed transaction to the PRC
  • txn sign - sign a given transaction
  • txn simulate - simulate and assemble transaction
  • signer::Stellar trait and a default InMemory implementation needed for txn sign

Left

  • [ ] Tests

willemneal avatar Apr 15 '24 19:04 willemneal

Given the sensitivity of the sign command, I'd like to shift that work into a separate PR, so that we can get the other commands merged sooner, then follow up and take our time with the sign command. There should be litle to no need for the commands to be added together, so I think that'll be fine, but please lmk @willemneal if you think that'd be a problem. cc @janewang

leighmcculloch avatar May 10 '24 01:05 leighmcculloch

Friend bot seems to be failing.

willemneal avatar May 14 '24 19:05 willemneal

@leighmcculloch I've removed send because it has hard to test without a proper sign command. So there is another PR to add all the remaining besides inspect.

willemneal avatar May 28 '24 15:05 willemneal