rs-soroban-env icon indicating copy to clipboard operation
rs-soroban-env copied to clipboard

Published 20 hours ago • verified publisher icon stellar

Remove pre_release_version from meta.rs

Open sisuresh opened this issue 10 months ago • 2 comments

What problem does your feature solve?

pre_release_version was helpful for the development of protocol 20 because of how often we iterated on the protocol, but going forward, we won't breaki a non-vnext build intentionally. The interface version (which contains both the protocol version and pre-release version) has caused confusion in the past, so we should just remove it.

sisuresh avatar Apr 03 '24 16:04 sisuresh

I propose an alternative solution to the problem in:

  • https://github.com/stellar/stellar-protocol/discussions/1476

leighmcculloch avatar Apr 04 '24 02:04 leighmcculloch

Now that we've separated the protocol and pre-release version in:

  • https://github.com/stellar/stellar-protocol/discussions/1476#discussioncomment-10504902

If we wanted to remove the pre-release version in the future we could do so by simply stopping using it, and renaming the field from preRelease to reserved or deprecated, just expecting it to be forever zero.

leighmcculloch avatar Sep 03 '24 02:09 leighmcculloch