Action waits for RPC to be healthy, but not Horizon and Friendbot

[leighmcculloch]

The GitHub Action in the action.yml file waits for the container to be healthy, but does so by testing the RPC endpoint. The RPC is faster at getting setup than Horizon and subsequently Friendbot that uses Horizon. So when the RPC is healthy, if an account funding is sent immediately, Friendbot will fail to handle the request.

The health check should ensure that all the services, or the last service to start up (Friendbot) are healthy.

To do this, it would probably be helpful to first do this:

• #683

cc @stellar/devx

[ifropc]

@leighmcculloch it does wait for Friendbot to be healthy (though, not very obviously) https://github.com/stellar/quickstart/blob/main/action.yml#L63-L64 <- this will only succeed when friendbot is healthy

[leighmcculloch]

Ah that's perfect. I still think there's value in wrapping that up in a single endpoint, but the need is less critical if the GHA already does it another way.

[ifropc]

I agree that having just 1 health endpoint would be ideal

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity.

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity.