new-docs icon indicating copy to clipboard operation
new-docs copied to clipboard

Different branches, different dependencies for app documentation

Open sarahmarshy opened this issue 3 years ago • 0 comments

I have needed to use your existing branches at the end of each tutorial step here - https://developers.stellar.org/docs/building-apps

One consistent thing that is wrong with each branch and/or the code shown on the website is the version of js-combinatorics sep-24 branch uses an outdated version, causing a compile error - https://github.com/stellar/docs-wallet/blob/sep24/package.json#L38

Correct one is 1.4.5 per the pay branch - https://github.com/stellar/docs-wallet/blob/pay/package.json#L38

This line in sep-24 branch is invalid for js-combinatorics. It's fixed in pay and trustline.

Basically, I expect these branched to be the "finished" app and should compile out of the box. Just a quick test of all of them could probably show you any errors I have missed.

sarahmarshy avatar Aug 22 '21 01:08 sarahmarshy