laboratory icon indicating copy to clipboard operation
laboratory copied to clipboard

txBuilder − Manage Buy Offer − Offer ID should be optional

Open MisterTicot opened this issue 5 years ago • 4 comments

It's all in the title. Currently the interface forces user to enter an offerId parameter, which doesn't match the network behavior.

MisterTicot avatar Jun 07 '19 11:06 MisterTicot

Hmm it doesn't say it's optional on the doc https://www.stellar.org/developers/guides/concepts/list-of-operations.html#manage-buy-offer

jeesunikim avatar Oct 07 '19 18:10 jeesunikim

We will update it so that if a user didn't specify a value in Offer ID input, it will be set to 0.

jeesunikim avatar Oct 07 '19 18:10 jeesunikim

Yes it does... Just look at the JS doc, that's the API you use :

https://stellar.github.io/js-stellar-sdk/Operation.html#.manageBuyOffer

MisterTicot avatar Oct 07 '19 21:10 MisterTicot

You're right.

We will update so that:

  1. offerId's default value is 0 (this isn't clear on laboratory at the moment)
  2. Add an optional attribute

Or I think we didn't include optional attribute intentionally on laboratory so that the user would have to type in either 0 or their offerID because it gives a warning at the end if its input value is empty.

Either way, we will clarify it! Thank you!

jeesunikim avatar Oct 07 '19 23:10 jeesunikim