js-stellar-sdk icon indicating copy to clipboard operation
js-stellar-sdk copied to clipboard

SEP-10 Manage Data Op Changes

Open JakeUrban opened this issue 5 years ago • 0 comments

The following changes were recently merged to SEP-10:

  • [] the Manage Data operation's key includes a homeDomain FQDN instead of the anchorName string
  • [] a SIGNING_KEY attribute in the stellar.toml of the service implementing SEP-10 is required
  • [] client applications must match the value of the Manage Data operation's key with the home domain used in the request for the service's TOML file
  • [] client applications must verify that the service's SIGNING_KEY keypair was used to sign the challenge transaction

Each SDK must update to enable the first and ideally third item in this list.

The SDF's JavaScript SDK released v5.0.5 recently including these changes.

The Go SDK may not support verifying the home domain from the Manage Data op key because it would require breaking changes to ReadChallengeTx() and other functions, compared to the strictly additive changes made to the JS SDK. If your SDK would also require breaking changes to implement this check, comment on this issue and we discuss the viability of different options.

If your SDK has implemented and released these changes, reference the release in a closing comment.

JakeUrban avatar Aug 28 '20 21:08 JakeUrban