stellar
New add/remove asset flow does not surface errors
What version are you using?
5.35.0
What did you do?
- Fund an account with 1 XLM
- Attempt to add USDC as a trustline
- Observe that you receive a tx failed error
What did you expect to see?
Copy telling me what went wrong (in this case, insufficient balance)
What did you see instead?
Does this need to be fixed in mobile, as well?
I don't think we've designed errors for this screen but yeah none of the platforms include detailed error messages here.
@sdfcharles could we have Figma designs for Failed submitted transactions in all flows for the extension and mobile? E.g. Add/Remove Token, Send, Swap, and Sign Transaction
I think having a dedicated space/section for the UI error message in our existing error screens would probably be enough. What do you think? Below are 2 samples (extension and mobile)
Similar issue on the mobile repo: https://github.com/stellar/freighter-mobile/issues/315
@sdfcharles could we have Figma designs for Failed submitted transactions in all flows for the extension and mobile? E.g. Add/Remove Token, Send, Swap, and Sign Transaction
I think having a dedicated space/section for the UI error message in our existing error screens would probably be enough. What do you think? Below are 2 samples (extension and mobile)
yep makes sense, will attach here when done 🫡
@sdfcharles looks good to me, thanks! @aristidesstaffieri @piyalbasu I was thinking we could use the fields suggested here to build the error messages. What do you think? Also please let us know in case you have further suggestions for the UI - thanks!
@sdfcharles looks good to me, thanks! @aristidesstaffieri @piyalbasu I was thinking we could use the fields suggested here to build the error messages. What do you think? Also please let us know in case you have further suggestions for the UI - thanks!
that seems good to me, further, I think we can find the rpc code that defines all of the possible errors and create maps of <raw error -> display string>. Imo we should stay away from using raw errors from rpc/horizon in the UI since they often don't mean much to a non-dev user.
Imo we should stay away from using raw errors from rpc/horizon in the UI since they often don't mean much to a non-dev user.
@aristidesstaffieri totally agree on it, I've included it as part of this other task.
Result XDR and response codes would be helpful for mapping to human-readable explanation for each error
