kelp icon indicating copy to clipboard operation
kelp copied to clipboard

[2] Values for amount and price are incorrect on exchanges with low precision

Open nikhilsaraf opened this issue 5 years ago • 3 comments

related to #435

Describe the bug

The bot is capping precision for amount and volume too early, which results in incorrect values.

Expected behavior

I think the correct behavior in this situation is for the bot to cap precision on volume and price as late as possible and use full-precision values for internal calculations

Frequency

The frequency is: Always (when precision is too low)

Possible Solution

This bug can be fixed by changing when we cap precision

nikhilsaraf avatar Jun 08 '20 15:06 nikhilsaraf

this can be solved by increasing the precision on the exchange as much as possible. If this is an issue for you, tag me on this issue.

nikhilsaraf avatar Jun 08 '20 16:06 nikhilsaraf

does this mean it's no longer a limitation of the go sdk?

ddombrowsky avatar Jun 19 '20 15:06 ddombrowsky

That's correct. Fixed in the Go SDK here: https://github.com/stellar/go/releases/tag/horizonclient-v3.1.0

ire-and-curses avatar Jun 19 '20 15:06 ire-and-curses