kelp icon indicating copy to clipboard operation
kelp copied to clipboard

[5] Protocol 12: path_payment type field change for fill tracker

Open nikhilsaraf opened this issue 4 years ago • 0 comments

Desired Behavior

I want to continue having support for fill tracking with the new protocol v12 upgrade

Impact

The desired behavior will allow me to continue operating Kelp through the new protocol v12 upgrade.

Feature Suggestion

the operations endpoint has a type and type_i field. Kelp uses only type in identifying the type of operation for the fill tracker, specifically trade, or path_payment.

In protocol 12 we will have types path_payment_strict_send and path_payment_strict_receive with possible backward compatibility for path_payment type.

Kelp would not recognize this new type so that needs to be fixed.

References

  • See previous change where support for the path_payment type was added.
  • CAP-0024 describing this change in stellar-core

nikhilsaraf avatar Sep 20 '19 19:09 nikhilsaraf